likho/microblog.py
2
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Link to images in RSS output #4

Merged
likho merged 1 commits from :rss_1 into rss_1 2025-09-06 20:24:27 +00:00
Conversation 7 Commits 1 Files Changed 4 +42 -16
eloitor commented 2025-09-05 07:59:18 +00:00
Contributor
Copy Link

Progress towards solving #1

Progress towards solving #1
eloitor added 2 commits 2025-09-05 07:59:18 +00:00
eloitor added 1 commit 2025-09-05 08:17:46 +00:00
eloitor added 1 commit 2025-09-05 08:52:24 +00:00
eloitor added 1 commit 2025-09-05 09:53:31 +00:00
eloitor added 1 commit 2025-09-05 10:25:07 +00:00
eloitor force-pushed rss_1 from cc86aa1d6d to 75e80c5993 2025-09-05 10:29:48 +00:00 Compare
eloitor added 1 commit 2025-09-05 10:57:51 +00:00
eloitor added 1 commit 2025-09-05 14:23:17 +00:00
eloitor added 1 commit 2025-09-05 15:03:37 +00:00
eloitor changed title from WIP: Link to images in RSS output to Link to images in RSS output 2025-09-05 15:04:11 +00:00
eloitor added 1 commit 2025-09-05 15:04:24 +00:00
eloitor commented 2025-09-05 15:04:50 +00:00
Author
Contributor
Copy Link

ready for review. I'll squash everything if you see it ok :)

ready for review. I'll squash everything if you see it ok :)
eloitor force-pushed rss_1 from 9884edff17 to 67fc816ca3 2025-09-05 15:08:34 +00:00 Compare
eloitor commented 2025-09-05 15:21:08 +00:00
Author
Contributor
Copy Link

oops I messed up this... I'll try to fix it.

Edit: fixed :)

oops I messed up this... I'll try to fix it. Edit: fixed :)
👀 1
eloitor force-pushed rss_1 from 67fc816ca3 to 07fdf16686 2025-09-05 15:37:47 +00:00 Compare
likho reviewed 2025-09-06 05:31:13 +00:00
src/rss.py Outdated
@ -41,0 +59,4 @@
abs_url = urljoin(base_url, core)
anchor = f"<a href=\"{escape(abs_url)}\">{escape(abs_url)}</a>"
words[i] = anchor + suffix
return words
likho commented 2025-09-06 05:31:13 +00:00
Owner
Copy Link

This is skipping markup by the HTML parser in the following block.

Meaning, RSS feeds won't have links or code blocks rendered.

This is skipping markup by the HTML parser in the following block. Meaning, RSS feeds won't have links or code blocks rendered.
eloitor commented 2025-09-06 06:07:56 +00:00
Author
Contributor
Copy Link

Hi, I tried to solve this but I'm not sure if I accomplished this since the example does not have code blocks. (and the output being in a single line makes it hard to compare the output of different iterations).

Also I don't know how to use the html parser and the function that truncates the description at the same time. Let me know if this is ok, or if you prefer to truncate it for RSS output...

Hi, I tried to solve this but I'm not sure if I accomplished this since the example does not have code blocks. (and the output being in a single line makes it hard to compare the output of different iterations). Also I don't know how to use the html parser and the function that truncates the description at the same time. Let me know if this is ok, or if you prefer to truncate it for RSS output...
likho commented 2025-09-06 06:20:42 +00:00
Owner
Copy Link

Could you scrap the is_atom logic in enrich_msg()?
Just let enrich_mesg operate independently of the export feed format.

Add:
Please don't define a separate HTML parser just for RSS feeds. The function only needs one.

Add 2:
If you open the feed in a web browser, the output might be more readable than if you opened in a text editor.

Could you scrap the `is_atom` logic in `enrich_msg()`? Just let `enrich_mesg` operate independently of the export feed format. Add: Please don't define a separate HTML parser just for RSS feeds. The function only needs one. Add 2: If you open the feed in a web browser, the output might be more readable than if you opened in a text editor.
👍 1
eloitor marked this conversation as resolved
eloitor added 1 commit 2025-09-06 06:04:13 +00:00
likho commented 2025-09-06 06:13:33 +00:00
Owner
Copy Link

Hey, I can see the image render as links on certain posts.

RE: enrich_msg()
You added another block with its own "for each word" loop and return.
Could you work with the pre-existing "for each word" loop (the one that is getting skipped over).

Additionally, the link is incorrect for generated galleries like:

https://likho.neocities.org/microblog/tags/test/#40

str vg-demo1.jpg becomes

(This is related to [post.gallery] in settlings.toml.)

Hey, I can see the image render as links on certain posts. RE: `enrich_msg()` You added another block with its own "for each word" loop and `return`. Could you work with the pre-existing "for each word" loop (the one that is getting skipped over). Additionally, the link is incorrect for generated galleries like: https://likho.neocities.org/microblog/tags/test/#40 str `vg-demo1.jpg` becomes * `https://likho.neocities.org/microblog/vg-demo.jpg` (404) in the feed * https://likho.neocities.org/microblog/images/vg-demo1.jpg on the page (This is related to `[post.gallery]` in settlings.toml.)
eloitor added 1 commit 2025-09-06 06:56:02 +00:00
eloitor added 1 commit 2025-09-06 07:59:01 +00:00
eloitor force-pushed rss_1 from 68a5b2be65 to 7ab7b06bb2 2025-09-06 08:01:33 +00:00 Compare
eloitor commented 2025-09-06 08:17:52 +00:00
Author
Contributor
Copy Link

Could you do a new review?

Thanks, looking at it on the browser makes it easier, and things like <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"> look different, which confused me a bit.

Could you do a new review? Thanks, looking at it on the browser makes it easier, and things like `<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">` look different, which confused me a bit.
👀 1
likho commented 2025-09-06 16:55:17 +00:00
Owner
Copy Link

It looks good to go.
I'll be sending your payment plus the bonus to your public address (8M5cnyAzRyxZYghZayTcedek2Lgk3HqAZPvtzXMWm6va:4LA) at 7 pm UTC.

I typically would give any time between now and then to let someone spot any mistakes in copying the address. It looks like that key is active, so any funds wouldn't be sent to the void regardless. (If you want it now, I can send it now.)

It looks good to go. I'll be sending your payment plus the bonus to your public address (`8M5cnyAzRyxZYghZayTcedek2Lgk3HqAZPvtzXMWm6va:4LA`) at 7 pm UTC. I typically would give any time between now and then to let someone spot any mistakes in copying the address. It looks like that key is active, so any funds wouldn't be sent to the void regardless. (If you want it now, I can send it now.)
eloitor commented 2025-09-06 20:14:35 +00:00
Author
Contributor
Copy Link

Thanks! :)

Thanks! :)
likho merged commit 4f9dcb5c80 into rss_1 2025-09-06 20:24:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
likho
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: likho/microblog.py#4
No description provided.
Delete Branch ":rss_1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?